FishEye

file alter_4_0_2_to_4_0_2_bps.sql was initially added on branch OLAT-4_0_2-BPS_UNIZH-1319.

add the REVIEW task name to see reviewed places where some questions arise of the BPS repository patch This is the reviewed BPS patch, without changes except added REVIEW messages - I see the need for a concept to jump between controllers as it is solved here by setting booleans to know where to jump back --- to jump from the catalog to the detail a ChangeEvent is used --- to jump from the course the activateable mechanism is used. - "upload a file" code is now replicated at several places (also the library's licence must be reviewed to be compatible with ours) - wizards should not be generated by subclassing this is stated from felix, now we should refactor the existing wizards not to use subclassing, as these may serve as base code for learning. -> Alexander Schneiders wizards InOutWizardController and BulkAssessmentWizardController show how to do it without subclassing. - Important small things: - use the constanst and not a value, where constants are defined , i.e. ChangedEvent.MODIFIED = 0 otherwise refactorings would generate errors. - introducing methods with almost the same signature but changing a new input value like boolean should not copy paste, but call the new method the corresponding default value. - introducing a new signature in a public method or constructor should not be done by refactoring all references but creating a new method. Then point the old one to the new one providing a default value.